also I disabled following tests

		and not test_php_application_disable_classes \
		and not test_php_application_disable_classes_user \

Can we limit the #ifdeferry to the nxt_php_disable() function itself?

Yes, it could be cleaner to limit ifdef to the function only but there's no zend structure anymore so yoou need to change calling code anyway.

src/nxt_php_sapi.c:715:33: error: use of undeclared identifier 'zend_disable_class'

Another option could be deprecation of disable_classes in php mod as it will be removed in php 9 anyway so this setting will gone someday...

So ATM it's not clear which way is preferable, moreover disabled_functions also full of ifdeffery(

It was just a thought.

I will probably squeeze this into 1.35.0 (which is likely to be the
final release for the foreseeable future...)

@andypost

Seeing as I don't have permissions to update this branch, can you rebase
with master and make the commit message this

php: Fix building with 8.5

Link: <https://github.com/php/php-src/commit/f4e2e91d4b6d28448104500819b68edf58bd263c>
Signed-off-by: Andy Postnikov <apostnikov@gmail.com>

Thanks!

Actually make the commit message

php: Fix building with 8.5

Closes: https://github.com/nginx/unit/issues/1646
Link: <https://github.com/php/php-src/commit/f4e2e91d4b6d28448104500819b68edf58bd263c>
Signed-off-by: Andy Postnikov <apostnikov@gmail.com>

(Note: no <> on the closes link as GitHub still doesn't recognise that)

doing

ready

EDIT: somehow I can grant permission allowing maintainers to allow edits(

Thanks!